Fix DID update metadata bug #17412

[geoffwalmsley]

Added a validation step to update_metadata ensuring a flat dict of key value pairs

[coveralls-official]

Pull Request Test Coverage Report for Build 7864185774

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
• 164 unchanged lines in 32 files lost coverage.
• Overall coverage decreased (-0.05%) to 90.822%

---

Files with Coverage Reduction	New Missed Lines	%
chia/daemon/server.py	1	88.56%
chia/data_layer/dl_wallet_store.py	1	95.74%
chia/data_layer/download_data.py	1	71.04%
chia/full_node/full_node_api.py	1	79.33%
chia/full_node/mempool.py	1	99.66%
chia/introducer/introducer.py	1	78.26%
chia/rpc/wallet_rpc_api.py	1	89.57%
tests/core/mempool/test_mempool_manager.py	1	99.89%
tests/core/util/test_file_keyring_synchronization.py	1	97.1%
tests/core/util/test_lockfile.py	1	91.5%

Totals
Change from base Build 7844390313:	-0.05%
Covered Lines:	96769
Relevant Lines:	106506

---

💛 - Coveralls

[Quexington]

Approving this as a good change, but noting that it doesn't fix the root issue in the linked issue which is that even if the transaction isn't going to succeed, there are still stateful side effects that put the wallet in a bad state. Might be worth looking into that as well.

[wjblanke]

aok