Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added chia start daemon #17704

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Added chia start daemon #17704

merged 5 commits into from
Mar 18, 2024

Conversation

ChiaMineJP
Copy link
Contributor

Now chia start daemon can be invoked.
The difference between chia run_daemon and chia start daemon is that the former captures its terminal until the process exists while the latter immediately returns control after the cli command.

This PR is required to fix a GUI bug where GUI never exits until its child process (daemon) stop by leaked file descriptors in Linux system.

@ChiaMineJP ChiaMineJP added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Mar 14, 2024
@ChiaMineJP ChiaMineJP requested review from altendky and arvidn March 14, 2024 17:06
@ChiaMineJP ChiaMineJP self-assigned this Mar 14, 2024
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner March 14, 2024 17:06
@ChiaMineJP ChiaMineJP force-pushed the cmj.chia-start-daemon branch from c341f60 to 988ca6c Compare March 14, 2024 18:01
@emlowe
Copy link
Contributor

emlowe commented Mar 14, 2024

It always did seem odd this wasn't available

chia/_tests/util/test_service_groups.py Outdated Show resolved Hide resolved
chia/cmds/stop.py Show resolved Hide resolved
chia/util/service_groups.py Outdated Show resolved Hide resolved
@pmaslana pmaslana merged commit 2f3fce5 into main Mar 18, 2024
284 checks passed
@pmaslana pmaslana deleted the cmj.chia-start-daemon branch March 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants