Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code in multiprocess_validation #17720

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Mar 16, 2024

Purpose:

We never pass HeaderBlock objects to multiprocess_validation(), only FullBlocks. Remove all code that handles HeaderBlocks in the multiprocess_validation path

This is best viewed ignoring whitespace changes, since there's a large block that got de-dented.

Current Behavior:

New Behavior:

Testing Notes:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…FullBlocks. Remove all code that handles HeaderBlocks in the multiprocess_validation path
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Mar 16, 2024
@arvidn arvidn marked this pull request as ready for review March 16, 2024 12:14
@arvidn arvidn requested a review from a team as a code owner March 16, 2024 12:14
Copy link
Contributor

File Coverage Missing Lines
chia/consensus/multiprocess_validation.py 89.1% lines 81, 148-152
Total Missing Coverage
55 lines 6 lines 89%

@arvidn
Copy link
Contributor Author

arvidn commented Mar 18, 2024

I think it's reasonable to ignore the missing test coverage. It's pre-existing and it's in the case of validation failure.

Copy link
Contributor

@almogdepaz almogdepaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn requested a review from emlowe March 18, 2024 10:34
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Mar 18, 2024
@pmaslana pmaslana merged commit f861c1e into main Mar 18, 2024
285 of 287 checks passed
@pmaslana pmaslana deleted the validate-header-blocks branch March 18, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants