refactor full_node add_block #18584
Draft
refactor full_node add_block #18584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almogdepaz
added
Blockchain team
arvidn
reviewed
Sep 12, 2024
| @@ -353,75 +352,19 @@ async def add_block( | |||
| # maybe fork_info should be mandatory to pass in, but we have a lot of | |||
There was a problem hiding this comment.
it looks like fork_info is mandatory now, and this comment could be updated
| if block_rec is not None: | ||
| self.add_block_record(block_rec) | ||
| # this means we have already seen and validated this block. | ||
| if fork_info is not None: |
There was a problem hiding this comment.
I don't think fork_info is allowed to be None now. mypy should complain
| @@ -1856,12 +1857,13 @@ async def test_pre_validation( | |||
| end_pv = time.time() | |||
| times_pv.append(end_pv - start_pv) | |||
| assert res is not None | |||
| fork_info = ForkInfo(-1, -1, empty_blockchain.constants.GENESIS_CHALLENGE) | |||
There was a problem hiding this comment.
so, blocks_to_validate[0].prev_header_hash == GENESIS_CHALLENGE seems to be assumed here. Is that really right? I think you'd need to pick the fork point hash out of blocks_to_validate[0]
| fork_height = block.height - len(fork_chain) - 1 | ||
| fork_info = ForkInfo(fork_height, fork_height, fork_hash) | ||
|
|
||
| log.warning(f"slow path in block validation. Building coin set for fork ({fork_height}, {block.height})") |
There was a problem hiding this comment.
we probably don't need this warning anymore now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
full node add_block is only used to add blocks on top of the current Peak, it does not need ForkInfo besides from the usage in tests, this pr removes that field and updates all the tests, this allows us to remove cases from blockchain.py add_block that dont serve us in node operation
Current Behavior:
New Behavior:
Testing Notes: