Simplify batch pre validate blocks #18602
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed one commit at a time.
Purpose:
We currently use
NPCResults
in many places where the error cannot be set. This PR is a small step towards using the (inner)SpendBundleConditions
directly in those cases.Specifically, it makes
batch_pre_validate_blocks()
take a dict ofSpendBundleConditions
instead ofNPCResults
.It also introduces an early exit in case
get_name_puzzle_conditions()
returns a failure.The
PreValidationResults
still contains anNPCResult
, as it's a bit more work to make it useSpendBundleConditions
directly. Although, it could; the error is not allowed to be set.Current Behavior:
batch_pre_validate_blocks()
takes a dict ofuint32
->NPCResult
.New Behavior:
batch_pre_validate_blocks()
takes a dict ofuint32
->SpendBundleConditions
.