-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-1427]: Limit full file creation when processing subscription generations #18612
Conversation
… max number of full files allowed
Pull Request Test Coverage Report for Build 10966220826Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good change to me. I put in a few code form comments, but I'm not strongly attached to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments are being considered separately for potential refactoring later
When syncing a subscription, DL downloads the delta files for each generation as it walks all the singleton generations. Currently each time it will also write out a full file - however, that full file isn't used and will be eventually deleted as the default is to only keep on full file.
This PR is an attempt to limit creating the full files except when we are within the range where we should generate the full files.
It will also create a full file if a delta file fails to download entirely - this makes sure that if in the middle of processing the deltas the code happens to be unable to move forward, a full file will get generated at that point.