Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1703] ignore ephemeral spends in mempool superset rule #18834

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 7, 2024

Purpose:

A transaction that creates an ephemeral coin can currently not be replaced-by-fee such that the ephemeral coin changes. This is because of the superset rule; to replace a transaction, all coins in the original TX must also be spent in the new TX.

Current Behavior:

The superset rule takes all spends into account.

New Behavior:

The superset rule only takes into account spends whose parent is not part of the spend bundle.

@arvidn arvidn requested a review from a team as a code owner November 7, 2024 08:06
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 7, 2024
Copy link

Pull Request Test Coverage Report for Build 11718949262

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.914%

Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/rpc/rpc_server.py 1 87.67%
chia/wallet/wallet_node.py 1 88.48%
chia/farmer/farmer_api.py 2 94.36%
chia/_tests/core/test_farmer_harvester_rpc.py 2 97.95%
chia/full_node/weight_proof.py 4 90.48%
chia/server/address_manager.py 5 90.48%
chia/server/node_discovery.py 10 79.82%
chia/full_node/full_node.py 11 86.0%
Totals Coverage Status
Change from base Build 11710907999: -0.02%
Covered Lines: 102863
Relevant Lines: 112911

💛 - Coveralls

@arvidn arvidn requested a review from wjblanke November 7, 2024 23:14
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Nov 8, 2024
@pmaslana pmaslana merged commit 80911d4 into main Nov 8, 2024
362 of 363 checks passed
@pmaslana pmaslana deleted the superset-ephemeral branch November 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants