Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that the what wallet the plotnft command is concerned with #18867

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 14, 2024

Purpose:

chia plotnft leave require you to specify a wallet ID. With the current description, it's not obvious whether you're supposed to specify the wallet you want to claim rewards into or the wallet that holds the plotnft itself. (it's the latter).

This change makes it clear when printing the command line help.

Current Behavior:

New Behavior:

Testing Notes:

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 14, 2024
@arvidn arvidn marked this pull request as ready for review November 14, 2024 12:00
@arvidn arvidn requested a review from a team as a code owner November 14, 2024 12:00
@aqk
Copy link
Contributor

aqk commented Nov 14, 2024

Suggest changing commit message to:

"clarify that the 'wallet plot id' is the plotnft wallet, not the rewards wallet"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants