Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary action_scope edit #19066

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

Quexington
Copy link
Contributor

Action scopes do, in fact, keep track of selected coins now, so we can delete this TODO

@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 18, 2024
@Quexington Quexington marked this pull request as ready for review December 18, 2024 20:10
@Quexington Quexington requested a review from a team as a code owner December 18, 2024 20:10
Copy link

Pull Request Test Coverage Report for Build 12398621134

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.533%

Files with Coverage Reduction New Missed Lines %
chia/timelord/timelord.py 1 80.0%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/timelord/timelord_launcher.py 1 89.29%
chia/_tests/core/util/test_lockfile.py 2 87.96%
chia/server/node_discovery.py 3 80.0%
Totals Coverage Status
Change from base Build 12395933591: 0.02%
Covered Lines: 104968
Relevant Lines: 114487

💛 - Coveralls

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Dec 19, 2024
@pmaslana pmaslana merged commit 60b6224 into main Dec 19, 2024
364 checks passed
@pmaslana pmaslana deleted the quex.delete_config_edit_scc branch December 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants