Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move all linter config to the root #9830

Merged
merged 1 commit into from
Jan 19, 2022
Merged

move all linter config to the root #9830

merged 1 commit into from
Jan 19, 2022

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 15, 2022 •
edited
Loading

This reduces duplication, symlinks, and makes the configurations available by default for the linting tools.

Draft for:

@altendky
move all linter config to the root
d778585 
This reduces duplication, symlinks, and makes the configurations
available by default for the linting tools.
hoffmang9
hoffmang9 approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@altendky
Copy link
Contributor Author

Pool timeouts addressed in #9817.

@altendky altendky marked this pull request as ready for review January 16, 2022 00:35
jack60612
jack60612 approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjblanke wjblanke merged commit 2a6564c into main Jan 19, 2022
@wjblanke wjblanke deleted the linter_config_in_root branch January 19, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

@jack60612 jack60612 jack60612 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altendky @jack60612 @hoffmang9 @wjblanke