Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memo parsing for offers #797

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix memo parsing for offers #797

merged 2 commits into from
Nov 22, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Nov 21, 2024

Fixes a bug where empty memo lists were treated the same as not having a memo list at all, which makes the announcement message different when fulfilling requested payments.

@Rigidity Rigidity requested a review from arvidn November 21, 2024 17:47
Copy link

Pull Request Test Coverage Report for Build 11958789434

Details

  • 75 of 76 (98.68%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 84.022%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-puzzles/src/puzzles/offer.rs 75 76 98.68%
Totals Coverage Status
Change from base Build 11929646879: 0.1%
Covered Lines: 12999
Relevant Lines: 15471

💛 - Coveralls

@Rigidity Rigidity merged commit 96b0c0a into main Nov 22, 2024
52 checks passed
@Rigidity Rigidity deleted the fix-offer-memos branch November 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants