Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secp256k1 and secp256r1 types #821

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Add secp256k1 and secp256r1 types #821

merged 5 commits into from
Dec 12, 2024

Conversation

Rigidity
Copy link
Contributor

No description provided.

@Rigidity Rigidity requested a review from arvidn December 12, 2024 14:23
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a fair amount of missing test coverage

crates/chia-secp/src/secp256k1/public_key.rs Outdated Show resolved Hide resolved
crates/chia-secp/src/secp256k1/public_key.rs Outdated Show resolved Hide resolved
crates/chia-secp/src/secp256k1/public_key.rs Outdated Show resolved Hide resolved
crates/chia-secp/src/secp256k1/secret_key.rs Outdated Show resolved Hide resolved
crates/chia-secp/src/secp256k1/secret_key.rs Outdated Show resolved Hide resolved
crates/chia-secp/src/secp256k1/signature.rs Outdated Show resolved Hide resolved
crates/chia-secp/src/secp256k1/signature.rs Outdated Show resolved Hide resolved
crates/clvm-traits/src/from_clvm.rs Outdated Show resolved Hide resolved
Copy link

coveralls-official bot commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12299677736

Details

  • 335 of 394 (85.03%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.972%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-secp/src/secp256k1/secret_key.rs 16 22 72.73%
crates/chia-secp/src/secp256k1/signature.rs 12 18 66.67%
crates/chia-secp/src/secp256r1/secret_key.rs 16 22 72.73%
crates/chia-secp/src/secp256r1/signature.rs 12 18 66.67%
crates/clvm-traits/src/from_clvm.rs 115 126 91.27%
crates/chia-secp/src/secp256k1/public_key.rs 15 27 55.56%
crates/chia-secp/src/secp256r1/public_key.rs 15 27 55.56%
Totals Coverage Status
Change from base Build 12286844688: 0.03%
Covered Lines: 13349
Relevant Lines: 15897

💛 - Coveralls

@Rigidity Rigidity requested a review from arvidn December 12, 2024 15:31
@Rigidity Rigidity merged commit 5741047 into main Dec 12, 2024
52 checks passed
@Rigidity Rigidity deleted the secp branch December 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants