Add unit test for an NA datetime in source #27
Assignees
Labels
Comments
|
Using Boston's 24-hour hotline dataset to create unit tests (same dataset that was the genesis of issue #24) |
dmpe
added a commit
to dmpe/RSocrata
that referenced
this issue
Jul 19, 2015
11 tasks
dmpe
added a commit
to dmpe/RSocrata
that referenced
this issue
Jul 23, 2015
3 tasks
dmpe
added a commit
to dmpe/RSocrata
that referenced
this issue
Dec 24, 2015
Merge pull request Chicago#51 from Chicago/dev Pull request for v1.6.1 Remove NEWS.md from build to avoid NOTE Build number bump and date change R 3.2.1 wants all URLs in canonical form--has been changed Fix type-o in Coveralls badge Merge remote-tracking branch 'upstream/dev' into dev split & improve 4x4 logic (tests pass) bump to 1.6.3 Add new Floatin Timestamp format for posixify + add test split validate + test validate url split test fix travis don't run, not do not run fix travis again add errorHandling function and rename getResponse to checkResponse update test else if [skip ci] add not finished test for Chicago#27, Chicago#24 [skip ci] go over sprint7 branch [skip ci] text/plain [skip ci] fix paste -> paste0 because of sep="" which I deleted delete note.md + update date [skip ci] geo readme Merge remote-tracking branch 'upstream/dev' into dev Merge remote-tracking branch 'origin/dev' into dev Conflicts: DESCRIPTION add geojson example & vignette (dependencies are suggested, later to be moved to required) should fix travis now fix again second time the same. give up give up on travis. wont work ? fix last time again tests and comments (geo too) update functions, move 4x4 to utils.R update docu + .md files add geojson support. not finished Merge pull request Chicago#53 from dmpe/dev Split functions and other smaller improvements fix leaflet example, not SP object but the list and add a new contributor fix test [skip ci] Merge pull request Chicago#56 from dmpe/dev-geojson-big bind -> rbind.fill; getMetadata; GeoJSON method Fixed version number scheme Using building numbers, x.y.z-b. The "z" should only be incremented on bug releases being planned. Human-readable URLs are not being deprecated Fixes build url under certain domain cases Re-added human-readable URL Added unit tests for broken-out URLs Removed unnecessary library listings Cleaned-up documentation Increment build info Updated help files Removed vignettes, updated documentation for style Example formatting issues, cleaned-up comments Turned on tests Examples on read.socrata taking too long, stopped their run Merge pull request #4 from Chicago/dev Dev
dmpe
added a commit
to dmpe/RSocrata
that referenced
this issue
Dec 24, 2015
Merge pull request Chicago#51 from Chicago/dev Pull request for v1.6.1 Remove NEWS.md from build to avoid NOTE Build number bump and date change R 3.2.1 wants all URLs in canonical form--has been changed Fix type-o in Coveralls badge Merge remote-tracking branch 'upstream/dev' into dev split & improve 4x4 logic (tests pass) bump to 1.6.3 Add new Floatin Timestamp format for posixify + add test split validate + test validate url split test fix travis don't run, not do not run fix travis again add errorHandling function and rename getResponse to checkResponse update test else if [skip ci] add not finished test for Chicago#27, Chicago#24 [skip ci] go over sprint7 branch [skip ci] text/plain [skip ci] fix paste -> paste0 because of sep="" which I deleted delete note.md + update date [skip ci] geo readme Merge remote-tracking branch 'upstream/dev' into dev Merge remote-tracking branch 'origin/dev' into dev Conflicts: DESCRIPTION add geojson example & vignette (dependencies are suggested, later to be moved to required) should fix travis now fix again second time the same. give up give up on travis. wont work ? fix last time again tests and comments (geo too) update functions, move 4x4 to utils.R update docu + .md files add geojson support. not finished Merge pull request Chicago#53 from dmpe/dev Split functions and other smaller improvements fix leaflet example, not SP object but the list and add a new contributor fix test [skip ci] Merge pull request Chicago#56 from dmpe/dev-geojson-big bind -> rbind.fill; getMetadata; GeoJSON method Fixed version number scheme Using building numbers, x.y.z-b. The "z" should only be incremented on bug releases being planned. Human-readable URLs are not being deprecated Fixes build url under certain domain cases Re-added human-readable URL Added unit tests for broken-out URLs Removed unnecessary library listings Cleaned-up documentation Increment build info Updated help files Removed vignettes, updated documentation for style Example formatting issues, cleaned-up comments Turned on tests Examples on read.socrata taking too long, stopped their run Merge pull request #4 from Chicago/dev Dev
dmpe
added a commit
to dmpe/RSocrata
that referenced
this issue
Dec 24, 2015
Merge pull request Chicago#51 from Chicago/dev Pull request for v1.6.1 Remove NEWS.md from build to avoid NOTE Build number bump and date change R 3.2.1 wants all URLs in canonical form--has been changed Fix type-o in Coveralls badge Merge remote-tracking branch 'upstream/dev' into dev split & improve 4x4 logic (tests pass) bump to 1.6.3 Add new Floatin Timestamp format for posixify + add test split validate + test validate url split test fix travis don't run, not do not run fix travis again add errorHandling function and rename getResponse to checkResponse update test else if [skip ci] add not finished test for Chicago#27, Chicago#24 [skip ci] go over sprint7 branch [skip ci] text/plain [skip ci] fix paste -> paste0 because of sep="" which I deleted delete note.md + update date [skip ci] geo readme Merge remote-tracking branch 'upstream/dev' into dev Merge remote-tracking branch 'origin/dev' into dev Conflicts: DESCRIPTION add geojson example & vignette (dependencies are suggested, later to be moved to required) should fix travis now fix again second time the same. give up give up on travis. wont work ? fix last time again tests and comments (geo too) update functions, move 4x4 to utils.R update docu + .md files add geojson support. not finished Merge pull request Chicago#53 from dmpe/dev Split functions and other smaller improvements fix leaflet example, not SP object but the list and add a new contributor fix test [skip ci] Merge pull request Chicago#56 from dmpe/dev-geojson-big bind -> rbind.fill; getMetadata; GeoJSON method Fixed version number scheme Using building numbers, x.y.z-b. The "z" should only be incremented on bug releases being planned. Human-readable URLs are not being deprecated Fixes build url under certain domain cases Re-added human-readable URL Added unit tests for broken-out URLs Removed unnecessary library listings Cleaned-up documentation Increment build info Updated help files Removed vignettes, updated documentation for style Example formatting issues, cleaned-up comments Turned on tests Examples on read.socrata taking too long, stopped their run Merge pull request #4 from Chicago/dev Dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue #24 raised the possibility of issues from posixify running when there is an NA value in a date/time field. While this issue seems to be resolved in #25, we should have a test for this on an ongoing basis.
While the test can be written, need a data source where there is a known blank in date/time column and is a relatively small dataset appropriate for unit tests (instead of downloading a large file each time).
The text was updated successfully, but these errors were encountered: