Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for v1.6.1 #51

Merged
merged 61 commits into from
Jul 11, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
86e9692
Add basic appveyor.yml file, ignore in R build
tomschenkjr Apr 21, 2015
3486709
Added unit testing to build scripts
tomschenkjr Apr 21, 2015
d470ad0
Added unit testing to build scripts
tomschenkjr Apr 21, 2015
b915ce8
Clean-up extraneous comments
tomschenkjr Apr 21, 2015
f8f6cd5
Fixed merge conficts
tomschenkjr Apr 21, 2015
81d7cca
Potential fix to run Rscript on test_script
tomschenkjr Apr 21, 2015
1715d8d
Added warnings_are_errors for appveyor and travis-ci
tomschenkjr Apr 21, 2015
8a74f52
Testing directory for Appveyor
tomschenkjr Apr 21, 2015
95fda86
Turn off WARNINGS_ARE_ERRORS to test unit testing capabilities
tomschenkjr Apr 22, 2015
b341597
Hard-removed WARNINGS_ARE_ERRORS for unit testing
tomschenkjr Apr 22, 2015
56ac9cf
Using double-quotes instead of single for Appveyor
tomschenkjr Apr 22, 2015
346b56f
roxygen2 now builds NAMESPACE, .Rd and collate files
tomschenkjr Apr 22, 2015
01c7352
Add roxygen2 to CI build scripts
tomschenkjr Apr 22, 2015
dc18695
Added CRAN repo; fixed quote marks
tomschenkjr Apr 22, 2015
016a776
Added AppVeyor badges, added warnings_as_errors, closes #39
tomschenkjr Apr 22, 2015
f4880c0
Bump build number
tomschenkjr Apr 22, 2015
35d4d4a
Updated badges layout to Shields.io
May 26, 2015
dd1add6
Merge branch 'iss39' of https://github.com/Chicago/RSocrata into dev
May 28, 2015
2550178
Build number bump
May 28, 2015
3b70692
Fixed AppVeyor icons
May 28, 2015
632ef04
Moved most 'Depends' packages to 'Imports' in DESCRIPTION. Added 'Imp…
geneorama Jun 5, 2015
f060f92
testing adding httr:: to parse_url to explicitly reference the proper…
geneorama Jun 5, 2015
e497cbe
using :: to reference all namespaces
geneorama Jun 5, 2015
577a48f
using :: to reference all namespaces
geneorama Jun 5, 2015
49cb9a9
increasing build number
geneorama Jun 5, 2015
7749221
Version bump to 1.6.1
Jun 6, 2015
16c58e9
Documentation clean-up, fixes #40
tomschenkjr Jun 6, 2015
69ae6fd
Contributing docs, closes #23 fix #28
tomschenkjr Jun 6, 2015
994ffa2
Updated release notes
tomschenkjr Jun 6, 2015
f624af5
Removed \url{...}. *Now* closes #40
Jul 4, 2015
d506619
update travis to a new version, i.e. proper "r" instead of old "c"
dmpe Jul 7, 2015
81e049f
divide in two steps
dmpe Jul 7, 2015
d763803
revert to the old inline style
dmpe Jul 7, 2015
98a655c
again
dmpe Jul 7, 2015
23db73c
upgrade packages to newer versions and remove `pck1::`
dmpe Jul 7, 2015
6b13eeb
upgrade description for the seocnd time
dmpe Jul 7, 2015
2916b7a
import all, not just specific functions
dmpe Jul 7, 2015
1b92240
Merge pull request #46 from dmpe/dev
Jul 7, 2015
ce84fd7
I have no idea what is being merge in what, and where is what being (…
dmpe Jul 8, 2015
b377cc7
delete curl dependency, unnecessary
dmpe Jul 8, 2015
0fe2457
smaller changes
dmpe Jul 8, 2015
04bb245
add @dmpe as an contributor
dmpe Jul 8, 2015
0134c71
6 test will still fail, without bigger changes to the code
dmpe Jul 8, 2015
57a3295
delete tests based on RUnit
dmpe Jul 8, 2015
d83530a
add coveralls badge to readme.
dmpe Jul 8, 2015
4b124e2
https://github.com/Chicago/RSocrata/pull/47#discussion-diff-34170071
dmpe Jul 8, 2015
cc1ba9f
@param a xxx -> should be @param a - xxx
dmpe Jul 8, 2015
835e978
Changed to square badges, inline placement
tomschenkjr Jul 10, 2015
ddb8fbb
All tests now working appropriately
tomschenkjr Jul 10, 2015
6d90340
Removed AppVeyor reference to RUnit tests
tomschenkjr Jul 10, 2015
42b46ee
Build number bump
tomschenkjr Jul 10, 2015
f4f7beb
update travis and add back ::s
dmpe Jul 10, 2015
bb8123c
update travis, and add 2 exported methods
dmpe Jul 10, 2015
2da69f1
do include man dir
dmpe Jul 10, 2015
4ebbaf6
no need for curl lib
dmpe Jul 10, 2015
8c5a9be
update readme (#48); split news/chagelog to its own file (better user…
dmpe Jul 10, 2015
5403fdb
update contributing.md to reflect the change to testthat
dmpe Jul 10, 2015
41854e0
resolving conflicts with pull request
geneorama Jul 10, 2015
e8fc7e4
Merge branch 'dmpe-import' into dev
geneorama Jul 10, 2015
1e9e055
deleted blank line
geneorama Jul 10, 2015
6e118d4
Updated documentation; re-added build number
Jul 10, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ RSocrata.Rcheck
^.*\.Rproj$
^\.Rproj\.user$
.DS_Store
README.md
^\.travis\.yml$
appveyor.yml
CONTRIBUTING.md
14 changes: 6 additions & 8 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
/.settings
/.git
/.project
/.Rbuildignore.Rcheck
/.README.md.html
/man
/.git
/RSocrata_*.tar.gz
/RCheck
/.settings
/DESCRIPTION.Rcheck
/out
/RCheck
/RSocrata_*.tar.gz
/RSocrata.Rcheck
*.pdf
/DESCRIPTION.Rcheck
/.Rbuildignore.Rcheck
*.Rproj.user
*.Rproj
*.Rproj.user
*.Rhistory
Expand Down
30 changes: 13 additions & 17 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,23 @@
#
# See README.md for instructions, or for more configuration options,
# see the wiki:
# https://github.com/craigcitro/r-travis/wiki
# http://docs.travis-ci.com/user/languages/r/

language: c
language: R
sudo: required
warnings_are_errors: true

env:
- R_MY_PKG="$(basename $TRAVIS_REPO_SLUG)"
r_github_packages:
- hadley/httr
- jeroenooms/jsonlite
- jeroenooms/curl
- klutometis/roxygen
- jimhester/covr

before_install:
- curl -OL http://raw.github.com/craigcitro/r-travis/master/scripts/travis-tool.sh
- chmod 755 ./travis-tool.sh
- ./travis-tool.sh bootstrap
install:
- ./travis-tool.sh install_deps
script:
- ./travis-tool.sh run_tests
- Rscript -e 'source("R/tests/testRSocrata.R"); runAllTestsCI()'

after_failure:
- ./travis-tool.sh dump_logs
after_success:
- Rscript -e 'library(covr);coveralls()'

notifications:
email:
on_success: change
on_failure: change
on_failure: change
25 changes: 25 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@

# How to contribute

We really appreciate when users [fix bugs](https://github.com/Chicago/RSocrata/pull/25) or [provide new features](https://github.com/Chicago/RSocrata/pull/21). When submitting changes, please read below to help the development team keep on top of issues and changes.

## Submitting a bug

If you notice something strange, please [submit an issue on GitHub](https://github.com/Chicago/RSocrata/issues). In the issue, please try to achieve the following:

* Describe what you did
* Describe what happened when you did it
* Describe what you think should happen
* If possible, describe where you think the error is occuring

If you have multiple issues, please submit multiple requests. Once you submit your report, we'll often engage in a conversation or give it a label to be fixed.

## Making Changes

When you want to make a change, either to fix a bug or introduce a new feature, please follow the instructions below

* Create a branch or fork of the project based off of the `dev` branch.
* Make commits of logical units
* Add unit tests for any new features
* Run all tests in `tests/testthat/`
* Create a pull request with a robust description or [reference the issue number](https://github.com/Chicago/RSocrata/issues)
28 changes: 15 additions & 13 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,25 +1,27 @@
Package: RSocrata
Type: Package
Title: Download 'Socrata' Data Sets as R Data Frames
Description: Provides easier interaction with
Socrata open data portals \url{http://dev.socrata.com}.
Socrata open data portals http://dev.socrata.com.
Users can provide a 'Socrata' data set resource URL,
or a 'Socrata' Open Data API (SoDA) web query,
or a 'Socrata' "human-friendly" URL,
returns an R data frame.
Converts dates to 'POSIX' format.
Manages throttling by 'Socrata'.
Version: 1.6.0-12
Date: 2015-4-20
URL: https://github.com/Chicago/RSocrata
BugReports: https://github.com/Chicago/RSocrata/issues
Version: 1.6.2-9
Date: 2015-7-10
Author: Hugh Devlin, Ph. D., Tom Schenk, Jr., and John Malc
Maintainer: "Tom Schenk Jr." <developers@cityofchicago.org>
Depends:
httr (>= 0.3),
jsonlite (>= 0.9.14),
mime (>= 0.2)
R (>= 3.0.0)
Imports:
curl (>= 0.5)
httr (>= 1.0.0),
jsonlite (>= 0.9.16),
mime (>= 0.3)
Suggests:
RUnit
Author: Hugh Devlin, Ph. D. and Tom Schenk, Jr.
Maintainer: "Tom Schenk Jr." <developers@cityofchicago.org>
License: MIT + file LICENSE
testthat (>= 0.10.0),
roxygen2 (>= 4.1.0)
License: MIT + file LICENSE
URL: https://github.com/Chicago/RSocrata
BugReports: https://github.com/Chicago/RSocrata/issues
18 changes: 13 additions & 5 deletions NAMESPACE
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
# Generated by roxygen2 (4.1.1): do not edit by hand

export(fieldName)
export(isFourByFour)
export(ls.socrata)
export(posixify)
export(read.socrata)
export(ls.socrata)
import(jsonlite)
import(httr)
import(mime)
import(curl)
export(validateUrl)
importFrom(httr,GET)
importFrom(httr,build_url)
importFrom(httr,content)
importFrom(httr,http_status)
importFrom(httr,parse_url)
importFrom(httr,stop_for_status)
importFrom(jsonlite,fromJSON)
importFrom(mime,guess_type)
45 changes: 45 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
### 1.1
Add check for valid Socrata resource URL. Add check for supported download file format. Add support for Socrata short dates.

### 1.2
Use comma-separated file format for Socrata downloads.

### 1.3
* Added support for human-readable URL. Users can now copy and paste URLs of Socrata-hosted datasets, which will be transformed into a valid SoDA API web query.

* Added additional RUnit tests to validate new functionality.

### 1.4
Add json file format for Socrata downloads. Switch to `RJSONIO` from `rjson`.

### 1.5 Several changes:

* Swapped to ```jsonlite``` from ```RJSONIO```
* Added handling for long and short dates
* Added unit test for reading private datasets

### 1.5.1
Deprecated ```httr::guess_media()``` and implemented ```mime::guess_type()```

### 1.6.0 Several changes:

* New function, ```ls.socrata``` to list all datasets on a Socrata portal.
* New optional argument, ```app_token```, which lets users supply an API token while using ```read.socrata()``` to minimize throttling.
* Repairs a bug where ```read.socrata``` failed when reading in a date with a column, but there are null values in that column.
* Minor changes to the DESCRIPTION documentation to point users to GitHub for issues and provides new contact information.

### 1.6.1 Bug fixes:

* Resolved potential [name collision issue](https://github.com/Chicago/RSocrata/issues/42)
* Cleaned-up documentation with contributor instructions [#23](https://github.com/Chicago/RSocrata/issues/23) and [#28](https://github.com/Chicago/RSocrata/issues/28))
* Moved test coverage in `RUnit` to `testthat` and implemented code coverage monitoring ([#41](https://github.com/Chicago/RSocrata/issues/41))
* Clean-up DESCRIPTION ([#40](https://github.com/Chicago/RSocrata/issues/40))
* Add continuous integration for Windows ([#39](https://github.com/Chicago/RSocrata/issues/39))
* Migrate Travis-CI to "proper" R YAML ([#46](https://github.com/Chicago/RSocrata/issues/46))







Loading