Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct URL/links to app resources/actions such as Advanced Search, Layers, Manage etc. #115

Closed
rladines opened this issue Sep 15, 2015 · 13 comments
Assignees
Milestone

Comments

@rladines
Copy link
Collaborator

rladines commented Sep 15, 2015

Only focus on Shareable Queries for now -- not adv search, layers, manage, etc.

Link to a query and executing that link.

@tomschenkjr
Copy link
Contributor

Like https://url.net/manage?

@rladines
Copy link
Collaborator Author

Right, or https://url.net/query?name=CouponTweets&autosubmit=true

It has to be designed so that the existing command buttons that currently invoke those panels/actions need to issue the same URL so it is consistent.

@tomschenkjr
Copy link
Contributor

I agree. Can you mark #134 as duplicated and close it?

@tomschenkjr
Copy link
Contributor

Have been using this on WindyGrid, but noticing some issue. Namely, issues are arising when sending the link because some programs are truncating the URL after the # symbol that are being used to define the colors.

For instance, this link is being truncated when embedding the link in a Microsoft Outlook email (e.g., inserting a link).

The hash/pound symbols aren't being encoded. However, when switching # to %23, the links are able to be shared and are also being properly interpreted by WG.

Would it be possible to encode the # in the URL being generated by the application?

/cc @geneorama

@reve0716
Copy link
Contributor

It works with newer version outlook and not with outlook desktop version 2010.

@tomschenkjr
Copy link
Contributor

tomschenkjr commented Jun 28, 2017 via email

@tomschenkjr
Copy link
Contributor

@nfspeedypur and @rladines - I see this issue is appearing in OpenGrid.io.

@rladines - did the patch you release in WindyGrid make it into the OpenGrid code or does that need to be ported?

@rladines
Copy link
Collaborator Author

It should be there. These are the commits that were part of that fix:
Main.js
AdvancedSearch.js

@nfspeedypur Can you confirm that these were merged into the OpenGrid.io code?

@tomschenkjr
Copy link
Contributor

Ok, looks like I didn't do the test right on my end. Closing for now. Thanks everyone!

@tomschenkjr tomschenkjr reopened this Jun 30, 2017
@tomschenkjr
Copy link
Contributor

I haven't been able to replicate the bug in WindyGrid, even by using the same query.

@rladines
Copy link
Collaborator Author

@tomschenkjr was able to recreate this, even on the windygrid side. we had a bug where a single replace is done instead of global. should be fixed with branch iss115. I will submit a PR for the fix.

@tomschenkjr
Copy link
Contributor

Closed by 8fe5094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants