M2-7745: fixing paragraph Text scroll on Android #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing the tests. |
ChaconC
requested changes
Sep 11, 2024
…lataform.OS to IS_ANDROID and removing * 0.8 from setKeyboardHeight
felipeMetaLab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-7745
Allowing user scroll downward in Android.
I am adding a extra padding always keyboard opens to allow user scroll down.
📸 Screenshots
IOS (didn't change):
https://github.com/user-attachments/assets/e7f7a74d-b8e4-4f50-b510-f86a49c33192
ANDROID:
https://github.com/user-attachments/assets/3733e49f-f7b3-4717-873f-f235bb3a4631
Testing Android with long description:
https://github.com/user-attachments/assets/e723d713-0eae-47aa-baf5-73b46f8bd73c
Result:
🪤 Peer Testing
1 - Build application on Android
2 - Create a ParagraphText item and add it to an applet
3 - Once you open Paragraph text, check if when keyboard is open you can scroll down or not.
✏️ Notes
on IOS there should be no changes