Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-552 ⁃ Scheduling of activities #302

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

odziem
Copy link
Contributor

@odziem odziem commented Nov 20, 2019

Rewrite activity scheduling logic including:

  • bucketing of activities into in-progress, due, scheduled, unscheduled, and completed
  • fetching the dayspan schedule from the getApplets API request
  • fetching response times from the getSchedule API request
  • reminder dots on activities and applets
  • reminder notifications

The complete list of activity buckets is:

  • In Progress, for activities that have been started but not completed.
  • Due, for activities currently scheduled - or - previously scheduled and not yet completed.
  • Scheduled, for activities scheduled some time in the future.
  • Unscheduled, for activities with no schedule.
  • Completed, for activities which have been completed and have no more scheduled occurrences.

Activity currently due:
Simulator Screen Shot - iPhone X - 2019-11-20 at 15 58 51

Activity completed and scheduled for next day:
Simulator Screen Shot - iPhone X - 2019-11-20 at 15 59 18

@binarybottle
Copy link
Member

binarybottle commented Nov 20, 2019

I liked the previous "Due: Today..." vs. "Due on: Today..."
For parallel structure, I would use "Scheduled: Nov..." rather than "Scheduled for: Nov..."

@binarybottle
Copy link
Member

I'm confused about the times in the screen capture -- the phone's time is 2:18, which I assume is 2:18pm, so it makes sense that 11am's activity is due (or technically overdue, depending on what the expected response time window would be, were we to set that), but why would the evening's notification be "Scheduled" for the next day, rather than later in the same day?

@odziem
Copy link
Contributor Author

odziem commented Nov 20, 2019

@binarybottle The previous screenshots demonstrated that the actual schedule can be arbitrary for each activity, e.g. the "Evening" activity can be scheduled for the morning. I've updated the description with screenshots demonstrating a more realistic scenario. Sorry for the confusion. 😄

The current screenshots show a scenario where the morning activity is scheduled between 10am-1pm and the evening activity is scheduled between 3pm-7pm.

On the topic of the due date label - this is something I'm hoping to change in a subsequent PR. Currently the date/time displaying after "Due on:" is the beginning of the scheduled interval for the activity. Semantically it would make more sense for the date/time to be the end of the interval the activity should be completed by. When I make that change I can also update the label to remove the "on".

Copy link
Member

@shnizzedy shnizzedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. 🎉

On the topic of the due date label - this is something I'm hoping to change in a subsequent PR. Currently the date/time displaying after "Due on:" is the beginning of the scheduled interval for the activity. Semantically it would make more sense for the date/time to be the end of the interval the activity should be completed by. When I make that change I can also update the label to remove the "on".

#302 (comment)

My thoughts as well. @binarybottle can we go ahead and merge this PR and leave the label for a later PR?

@binarybottle binarybottle merged commit e739b49 into ChildMindInstitute:master Nov 21, 2019
@odziem odziem deleted the feat-scheduling branch November 21, 2019 16:01
@binarybottle binarybottle changed the title Scheduling of activities ML-552 ⁃ Scheduling of activities Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants