-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML-552 ⁃ Scheduling of activities #302
ML-552 ⁃ Scheduling of activities #302
Conversation
I liked the previous "Due: Today..." vs. "Due on: Today..." |
I'm confused about the times in the screen capture -- the phone's time is 2:18, which I assume is 2:18pm, so it makes sense that 11am's activity is due (or technically overdue, depending on what the expected response time window would be, were we to set that), but why would the evening's notification be "Scheduled" for the next day, rather than later in the same day? |
@binarybottle The previous screenshots demonstrated that the actual schedule can be arbitrary for each activity, e.g. the "Evening" activity can be scheduled for the morning. I've updated the description with screenshots demonstrating a more realistic scenario. Sorry for the confusion. 😄 The current screenshots show a scenario where the morning activity is scheduled between 10am-1pm and the evening activity is scheduled between 3pm-7pm. On the topic of the due date label - this is something I'm hoping to change in a subsequent PR. Currently the date/time displaying after "Due on:" is the beginning of the scheduled interval for the activity. Semantically it would make more sense for the date/time to be the end of the interval the activity should be completed by. When I make that change I can also update the label to remove the "on". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. 🎉
On the topic of the due date label - this is something I'm hoping to change in a subsequent PR. Currently the date/time displaying after "Due on:" is the beginning of the scheduled interval for the activity. Semantically it would make more sense for the date/time to be the end of the interval the activity should be completed by. When I make that change I can also update the label to remove the "on".
My thoughts as well. @binarybottle can we go ahead and merge this PR and leave the label for a later PR?
Rewrite activity scheduling logic including:
dayspan
schedule from thegetApplets
API requestgetSchedule
API requestThe complete list of activity buckets is:
Activity currently due:
Activity completed and scheduled for next day: