Fixes #1210. Create a new service scope when cloning RequestContext #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stContext Doing so ensures that any queries that use the cloned context get their own scoped service instances instead of using the scoped service instances of the original RequestContext. This solves the issue of inadvertently having subscription event queries use the service scope of the originating long-lived subscription request. See issue ChilliCream#1210
|
Hi @rafd123, had to really look at the impact on this one, but it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new service scope when cloning RequestContext
Doing so ensures that any queries that use the cloned context get their
own scoped service instances instead of using the scoped service instances
of the original RequestContext.
This solves the issue of inadvertently having subscription event queries
use the service scope of the originating long-lived subscription request.
Addresses #1210