Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GraphQL Query Conventions #6846

Merged
merged 24 commits into from
Feb 9, 2024
Merged

Adds GraphQL Query Conventions #6846

merged 24 commits into from
Feb 9, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Jan 23, 2024

  • Adds Query Conventions
  • Reworks Data to help with features like query conventions
  • Removes lock files

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@e2308ce). Click here to learn what that means.

❗ Current head 068eff9 differs from pull request most recent head 52904d4. Consider uploading reports for the commit 52904d4 to get more accurate results

Files Patch % Lines
src/HotChocolate/Core/src/Types/Types/UnionType.cs 43.75% 9 Missing ⚠️
...pes.Mutations/MutationConventionTypeInterceptor.cs 80.00% 4 Missing ⚠️
.../Core/src/Types/Types/ObjectType.Initialization.cs 73.33% 4 Missing ⚠️
...te/Core/src/Types/Types/Pagination/PagingHelper.cs 69.23% 4 Missing ⚠️
...te/Core/src/Types/Internal/TypeInfo.RuntimeType.cs 66.66% 3 Missing ⚠️
...b/src/Data/Sorting/Handlers/MongoDbSortProvider.cs 89.28% 3 Missing ⚠️
.../src/Data/Projections/ProjectionTypeInterceptor.cs 87.50% 2 Missing ⚠️
...rojections/Convention/MongoDbProjectionProvider.cs 92.85% 2 Missing ⚠️
...Chocolate/Core/src/Types/Internal/TypeComponent.cs 83.33% 1 Missing ⚠️
.../src/Types/Types/Factories/DirectiveTypeFactory.cs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6846   +/-   ##
=======================================
  Coverage        ?   69.52%           
=======================================
  Files           ?     2571           
  Lines           ?   127989           
  Branches        ?        0           
=======================================
  Hits            ?    88978           
  Misses          ?    39011           
  Partials        ?        0           
Flag Coverage Δ
unittests 69.52% <91.54%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 23, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib merged commit 1634426 into main Feb 9, 2024
12 of 13 checks passed
@michaelstaib michaelstaib deleted the mst/query-conventions branch February 9, 2024 02:50
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant