Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Paging Helpers #7157

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fixed Paging Helpers #7157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e2f21a
Fixed paging helpers
PascalSenn Jun 8, 2024
199a8a2
Fixed snaphsots
PascalSenn Jun 8, 2024
0056c6e
Fixed ID tests
PascalSenn Jun 8, 2024
0ffd588
Merge branch 'main' into pse/fixed-paging-helpers
michaelstaib Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HotChocolate/Data/src/EntityFramework/Extensions/PagingResultExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ private static Connection<T> CreateConnection<T>(Page<T> page) where T : class
return new Connection<T>(
page.Items.Select(t => new Edge<T>(t, page.CreateCursor)).ToArray(),
new ConnectionPageInfo(
page.HasPreviousPage,
page.HasNextPage,
page.HasPreviousPage,
CreateCursor(page.First, page.CreateCursor),
CreateCursor(page.Last, page.CreateCursor)));
}
Expand Down
4 changes: 2 additions & 2 deletions ...ityFramework.Tests/__snapshots__/IntegrationPagingHelperTests.GetDefaultPage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
}
],
"pageInfo": {
"hasNextPage": true,
"hasPreviousPage": false,
"hasNextPage": false,
"hasPreviousPage": true,
"startCursor": "QnJhbmQwOjE=",
"endCursor": "QnJhbmQxNzoxOA=="
}
Expand Down
4 changes: 2 additions & 2 deletions ....Tests/__snapshots__/IntegrationPagingHelperTests.GetSecondPage_With_2_Items.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
}
],
"pageInfo": {
"hasNextPage": true,
"hasPreviousPage": false,
"hasNextPage": false,
"hasPreviousPage": true,
"startCursor": "QnJhbmQxODoxOQ==",
"endCursor": "QnJhbmQxOToyMA=="
}
Expand Down
4 changes: 2 additions & 2 deletions src/HotChocolate/Data/test/Data.Filters.InMemory.Tests/QueryableFilterVisitorIdTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,12 +458,12 @@ public async Task Create_ShortNullableNotEqual_Expression()
// act
var res1 = await tester.ExecuteAsync(
OperationRequestBuilder.Create()
.SetDocument("{ root(where: { barShort: { neq: \"Rm9vOjEy==\"}}){ barShort}}")
.SetDocument("{ root(where: { barShort: { neq: \"Rm9vOjEy\"}}){ barShort}}")
.Build());

var res2 = await tester.ExecuteAsync(
OperationRequestBuilder.Create()
.SetDocument("{ root(where: { barShort: { neq: \"Rm9vOjEz==\"}}){ barShort}}")
.SetDocument("{ root(where: { barShort: { neq: \"Rm9vOjEz\"}}){ barShort}}")
.Build());

var res3 = await tester.ExecuteAsync(
Expand Down
Loading