Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitted requireOneSlicingArgument if not set in listSize directive #7418

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 2, 2024

Summary of the changes (Less than 80 chars)

  • Omitted requireOneSlicingArgument if not set in listSize directive.

Closes #7398


Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (2df21d7) to head (dc5df32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7418      +/-   ##
==========================================
- Coverage   73.92%   73.91%   -0.01%     
==========================================
  Files        2853     2853              
  Lines      148656   148660       +4     
  Branches    17271    17271              
==========================================
- Hits       109895   109886       -9     
- Misses      33007    33026      +19     
+ Partials     5754     5748       -6     
Flag Coverage Δ
unittests 73.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as draft September 4, 2024 08:32
@michaelstaib michaelstaib self-assigned this Sep 24, 2024
@michaelstaib michaelstaib self-requested a review September 24, 2024 09:56
@michaelstaib michaelstaib marked this pull request as ready for review September 29, 2024 20:41
@glen-84 glen-84 added this to the HC-15.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omit requireOneSlicingArgument from @listSize if false
2 participants