Skip to content

Use PipeWriter instead of ArrayWriter when writing to outputStream #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

Use PipeWriter instead of ArrayWriter when writing to outputStream #8476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions src/HotChocolate/Core/src/Execution/Serialization/JsonResultFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System.Buffers;
using System.Collections;
using System.IO.Pipelines;
using System.Runtime.CompilerServices;
using System.Text;
using System.Text.Json;
Expand Down Expand Up @@ -226,29 +227,24 @@ private async ValueTask FormatInternalAsync(
Stream outputStream,
CancellationToken cancellationToken = default)
{
using var buffer = new ArrayWriter();
FormatInternal(result, buffer);

await outputStream
.WriteAsync(buffer.GetWrittenMemory(), cancellationToken)
.ConfigureAwait(false);

await outputStream.FlushAsync(cancellationToken).ConfigureAwait(false);
var writer = PipeWriter.Create(outputStream, new StreamPipeWriterOptions(leaveOpen: true));
FormatInternal(result, writer);
await writer.CompleteAsync().ConfigureAwait(false);
}

private async ValueTask FormatInternalAsync(
OperationResultBatch resultBatch,
Stream outputStream,
CancellationToken cancellationToken = default)
{
using var buffer = new ArrayWriter();
var writer = PipeWriter.Create(outputStream, new StreamPipeWriterOptions(leaveOpen: true));

foreach (var result in resultBatch.Results)
{
switch (result)
{
case IOperationResult singleResult:
FormatInternal(singleResult, buffer);
FormatInternal(singleResult, writer);
break;

case IResponseStream batchResult:
Expand All @@ -259,7 +255,7 @@ private async ValueTask FormatInternalAsync(
{
try
{
FormatInternal(partialResult, buffer);
FormatInternal(partialResult, writer);
}
finally
{
Expand All @@ -271,39 +267,31 @@ private async ValueTask FormatInternalAsync(
}
}

await outputStream
.WriteAsync(buffer.GetWrittenMemory(), cancellationToken)
.ConfigureAwait(false);

await outputStream.FlushAsync(cancellationToken).ConfigureAwait(false);
await writer.CompleteAsync().ConfigureAwait(false);
}

private async ValueTask FormatInternalAsync(
IResponseStream batchResult,
Stream outputStream,
CancellationToken cancellationToken = default)
{
using var buffer = new ArrayWriter();
var writer = PipeWriter.Create(outputStream, new StreamPipeWriterOptions(leaveOpen: true));

await foreach (var partialResult in batchResult.ReadResultsAsync()
.WithCancellation(cancellationToken)
.ConfigureAwait(false))
{
try
{
FormatInternal(partialResult, buffer);
FormatInternal(partialResult, writer);
}
finally
{
await partialResult.DisposeAsync().ConfigureAwait(false);
}
}

await outputStream
.WriteAsync(buffer.GetWrittenMemory(), cancellationToken)
.ConfigureAwait(false);

await outputStream.FlushAsync(cancellationToken).ConfigureAwait(false);
await writer.CompleteAsync().ConfigureAwait(false);
}

private void WriteResult(Utf8JsonWriter writer, IOperationResult result)
Expand Down
Loading