Skip to content

fix(serialization): Replace redundant round-trip in JsonSerializer.Parse with Clone #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

fix(serialization): Replace redundant round-trip in JsonSerializer.Parse with Clone #8536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ca7e8
fix(serialization): Replace redundant round-trip in JsonSerializer.Pa…
SindriFr Aug 14, 2025
5301d99
Merge branch 'main' into fix/unnecessary-json-serializer-round-trip
michaelstaib Aug 14, 2025
9c32221
Merge branch 'main' into fix/unnecessary-json-serializer-round-trip
michaelstaib Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/StrawberryShake/Client/src/Core/Serialization/JsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,7 @@ public JsonSerializer(string typeName = BuiltInScalarNames.Any)

public override JsonElement Parse(JsonElement serializedValue)
{
using var writer = new ArrayWriter();

// write json value to buffer.
using var jsonWriter = new Utf8JsonWriter(writer);
serializedValue.WriteTo(jsonWriter);
jsonWriter.Flush();

// now we read the buffer and create an element that does not need to be disposed.
var reader = new Utf8JsonReader(writer.GetWrittenSpan(), true, default);
return JsonElement.ParseValue(ref reader);
return serializedValue.Clone();
}

protected override JsonElement Format(JsonElement runtimeValue)
Expand Down
Loading