-
-
Notifications
You must be signed in to change notification settings - Fork 799
Sort nodes alphabetically when generating selection expressions #8551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelstaib
merged 4 commits into
ChilliCream:main
from
Cyberboss:FixExpressionHashDifferences
Aug 18, 2025
Merged
Sort nodes alphabetically when generating selection expressions #8551
michaelstaib
merged 4 commits into
ChilliCream:main
from
Cyberboss:FixExpressionHashDifferences
Aug 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hey @Cyberboss can you redo it against main ... we always fix main than cherry pick it onto main-version-15. |
michaelstaib
requested changes
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be retargeted to main.
This helps prevent differences when the expression hash is later used to branch data loaders if queries only differ in the order their fields are listed in.
9ed148c
to
f2c888a
Compare
michaelstaib
approved these changes
Aug 18, 2025
michaelstaib
added a commit
that referenced
this pull request
Aug 27, 2025
Co-authored-by: Michael Staib <michael@chillicream.com>
This was referenced Aug 27, 2025
This was referenced Sep 8, 2025
Closed
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍒 cherry-pick
Consider cherry-picking these changes into the previous major version.
🌶️ hot chocolate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following query will create two branches in a data loader when used with
QueryContext<>
andIDataLoader.With()
and thus result in two identical database queries being executed despite both selecting the exact same columns of the exact same entity.This is purely because the order of the assignments differ in the MemberInit expressions when the
ISelection
is converted to anExpression<Func<TResult, TResult>>
. This change ensures fields are always processed alphabetically to minimize hash differences where possible.Made these changes exclusively against v15. I assume they will be merged into
main
somehow?