Fix race condition on MethodInfo.GetParameters() #8778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
added
the
🍒 cherry-pick
tobias-tengler
force-pushed
the
tte/fix-concurrent-parameterinfo-lookup
branch
2 times, most recently
from
ab9ebd3 to
8aeee8d
Compare
|
Actually, this is not the fix :D This would just make the window smaller. |
tobias-tengler
force-pushed
the
tte/fix-concurrent-parameterinfo-lookup
branch
from
8aeee8d to
778d3ba
Compare
michaelstaib
approved these changes
Oct 8, 2025
michaelstaib
pushed a commit
that referenced
this pull request
Oct 8, 2025
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8433
RuntimeMethodInfo.GetParametersis not thread-safe, but we request parameters in a variety of places during type initialization. Because of this we could end up with two differentParameterInfoinstances for the same parameter, which leads to the missing dictionary key error reported in the linked issue.This PR addresses this issue by adding a new thread-safe
ITypeInspector.GetParameters()that also caches the parameter instances, similar toGetMembers.After Feedback from Michael I also added a
ParameterInfoComparerthat ensures that this also works if we ever decide to make theExtendedMethodInfopublic and there's a race condition between us and the developer callingGetParameters.