Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stitching list values #946

Merged
merged 19 commits into from
Aug 4, 2019
Merged

Fixed stitching list values #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f7976ac
Added GetCustomers property to test schema
michaelstaib Aug 3, 2019
2c8e4ac
Fixed list variable issue
michaelstaib Aug 4, 2019
9e5ebd3
updated snapshots
michaelstaib Aug 4, 2019
9f914ea
Added some list type tests
michaelstaib Aug 4, 2019
17c651b
added more tests
michaelstaib Aug 4, 2019
914b11c
fixed assertion in test
michaelstaib Aug 4, 2019
988cd50
Generalized wrapper type implementation code
michaelstaib Aug 4, 2019
b15eede
renamed wrapper type to NonNamedType
michaelstaib Aug 4, 2019
3d5670b
added more tests
michaelstaib Aug 4, 2019
846bef5
cleanup
michaelstaib Aug 4, 2019
26773c2
added more tests
michaelstaib Aug 4, 2019
d3db486
added more tests
michaelstaib Aug 4, 2019
c4f0ada
Cleanup
michaelstaib Aug 4, 2019
01c0a52
Fixed some tests
michaelstaib Aug 4, 2019
d3b3359
Added more tests
michaelstaib Aug 4, 2019
fc8b4b5
Added nonnulltype tests
michaelstaib Aug 4, 2019
9f80721
Added more nonnulltype tests
michaelstaib Aug 4, 2019
507a8cd
Added more tests
michaelstaib Aug 4, 2019
e09c7ba
more nonnulltype and listtype tests
michaelstaib Aug 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/Core/Types.Tests/Types/InputCoercionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using HotChocolate.Language;
using Xunit;

Expand Down Expand Up @@ -72,7 +73,7 @@ public void InputListIsInstanceOf()
public void ListCanBeCoercedFromListValue()
{
// arrange
var type = new ListType(new BooleanType());
var type = (IInputType)new ListType(new BooleanType());
var list = new ListValueNode(
new[] {
new BooleanValueNode(true),
Expand All @@ -82,8 +83,8 @@ public void ListCanBeCoercedFromListValue()
object coercedValue = type.ParseLiteral(list);

// assert
Assert.IsType<bool[]>(coercedValue);
Assert.Collection((bool[])coercedValue,
Assert.Collection(
Assert.IsType<List<bool?>>(coercedValue),
t => Assert.True(t),
t => Assert.False(t));
}
Expand All @@ -92,23 +93,23 @@ public void ListCanBeCoercedFromListValue()
public void ListCanBeCoercedFromListElementValue()
{
// arrange
var type = new ListType(new BooleanType());
var type = (IInputType)new ListType(new BooleanType());
var element = new BooleanValueNode(true);

// act
object coercedValue = type.ParseLiteral(element);

// assert
Assert.IsType<bool[]>(coercedValue);
Assert.Collection((bool[])coercedValue,
Assert.Collection(
Assert.IsType<List<bool?>>(coercedValue),
t => Assert.True(t));
}

[Fact]
public void ListCannotBeCoercedFromMixedList()
{
// arrange
var type = new ListType(new BooleanType());
var type = (IInputType)new ListType(new BooleanType());
var list = new ListValueNode(
new IValueNode[] {
new BooleanValueNode(true),
Expand All @@ -125,7 +126,7 @@ public void ListCannotBeCoercedFromMixedList()
public void ListCannotBeCoercedIfElementTypeDoesNotMatch()
{
// arrange
var type = new ListType(new BooleanType());
var type = (IInputType)new ListType(new BooleanType());
var element = new StringValueNode("foo");

// act
Expand Down Expand Up @@ -171,7 +172,7 @@ private void InputListIsInstanceOfInternal<TElement>(
where TElement : ScalarType, new()
{
// arrange
var type = new ListType(new TElement());
var type = (IInputType)new ListType(new TElement());

// act
bool isInstanceOfType = type.IsInstanceOfType(literal);
Expand All @@ -185,7 +186,7 @@ private void InputListIsNotInstanceOfInternal<TElement>(
where TElement : ScalarType, new()
{
// arrange
var type = new ListType(new TElement());
var type = (IInputType)new ListType(new TElement());

// act
bool isInstanceOfType = type.IsInstanceOfType(literal);
Expand Down
Loading