Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visibleTextRange made public #24

Merged
merged 1 commit into from
Aug 30, 2023
Merged

visibleTextRange made public #24

merged 1 commit into from
Aug 30, 2023

Conversation

kaunteya
Copy link
Contributor

No description provided.

@mattmassicotte
Copy link
Contributor

Can you remind me why you need this? I'm slightly worried about conflicts, as this library really isn't supposed to be messing with NSTextView.

@kaunteya
Copy link
Contributor Author

I have implemented my own highlight handler that conforms to TextSystemInterface. Need access to visibleRect

@mattmassicotte
Copy link
Contributor

Right right!

@mattmassicotte mattmassicotte merged commit f1dbf41 into ChimeHQ:main Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaunteya @mattmassicotte