Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default channel selection when owner change (if unique channel) #2240

Closed
klorydryk opened this issue Nov 13, 2019 · 1 comment · Fixed by #3382
Closed

Default channel selection when owner change (if unique channel) #2240

klorydryk opened this issue Nov 13, 2019 · 1 comment · Fixed by #3382
Labels
good first issue Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion

Comments

@klorydryk
Copy link

PeerTube v1.4.1

In /my-account/ownership , when I receive an owner change request, there is a pop-up to select the video channel. By default, the selector is empty.
If there is only 1 channel available, this channel should be selected by default, as there is no alternative.
@Chocobozzz Chocobozzz added UI non-trivial UI changes, that might need discussion good first issue labels Apr 17, 2020
@Poslovitch
Copy link
Contributor

Working on this.

Poslovitch added a commit to Poslovitch/PeerTube that referenced this issue Nov 29, 2020
@Poslovitch
Select first available channel when accepting ownership change
d29d797 
Implements Chocobozzz#2240
@Poslovitch Poslovitch mentioned this issue Nov 29, 2020
Merged
5 tasks
Chocobozzz pushed a commit that referenced this issue Dec 1, 2020
@Poslovitch
Select first available channel when accepting ownership change (#3382)
a3f1595 
* Select first available channel when accepting ownership change

Implements #2240

* Made use of #patchValue() to set the default selected value

And removed the disabled state for the Accept button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Type: Feature Request ✨ UI non-trivial UI changes, that might need discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Select first available channel when accepting ownership change Poslovitch/PeerTube
3 participants
@klorydryk @Chocobozzz @Poslovitch