-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to display full list in About page #2688
Conversation
I think the user would expect that button to go to the bottom of that list and have a reversed action and name ("hide full list"). |
client/src/app/+about/about-follows/about-follows.component.html
Outdated
Show resolved
Hide resolved
client/src/app/+about/about-follows/about-follows.component.scss
Outdated
Show resolved
Hide resolved
client/src/app/+about/about-follows/about-follows.component.html
Outdated
Show resolved
Hide resolved
I think it won't matter that much. Why would he want to hide the full list if he chose to display it? |
Various reasons, maybe he has clicked it by mistake or perhaps he wanted to search for a specific name (via ctrl+F) and then hide one list and open the second one. But it just feels right to have a way of reverting back whatever you've done, I even remember reading about this somewhere, it's how good designs are made.
https://xd.adobe.com/ideas/process/ui-design/4-golden-rules-ui-design/ |
You are totally right. I will keep that in mind in the future. |
I hope you meant not to hide the entire list, just revert it back to how it was before the user has clicked that button :) thank you |
My bad! Yes that's what I meant. |
Now the user has the option to show the full list, and when it's pressed, the user can scroll down, hide the full list and will only see the first 20 followers/followings. |
This comment has been minimized.
This comment has been minimized.
@rigelk Is there anything more that needs to be done on this (except solving the file conflict)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kontrollanten yes, showing the count of instances. The UI for empty lists has not been worked on either (buttons should not appear), and actions should match the color scheme for links.
@MahdiTurki Thanks for your contribution! Do you think that you can do the last fixes requested by @rigelk ? It would be nice to be able to merge this :) |
Hi, sure thing. I will start working on them soon.
@rigelk, I don't get what you mean exactly, could you please elaborate more? |
@MahdiTurki just have links use the main color 😉 |
Is it the Show more/less links that you're thinking of? I guess we should add the |
Either is fine |
I managed to display the count of instances. I tested with 2 different instances and it worked fine. |
Merged manually. Thanks @MahdiTurki |
#2397
Instead of scrolling down to get more followers/followings, the user can press show full list that will display the full list. The button will disappear when pressed and the full list is displayed.
I haven't managed to display the number of followers/followings.