Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to display full list in About page #2688

Closed
wants to merge 6 commits into from

Conversation

MahdiTurki
Copy link
Contributor

#2397

Instead of scrolling down to get more followers/followings, the user can press show full list that will display the full list. The button will disappear when pressed and the full list is displayed.
I haven't managed to display the number of followers/followings.

@ghost
Copy link

ghost commented Apr 27, 2020

The button will disappear when pressed and the full list is displayed.

I think the user would expect that button to go to the bottom of that list and have a reversed action and name ("hide full list").

@MahdiTurki MahdiTurki requested a review from rigelk April 27, 2020 12:20
@MahdiTurki
Copy link
Contributor Author

The button will disappear when pressed and the full list is displayed.

I think the user would expect that button to go to the bottom of that list and have a reversed action and name ("hide full list").

I think it won't matter that much. Why would he want to hide the full list if he chose to display it?

@ghost
Copy link

ghost commented Apr 27, 2020

I think it won't matter that much. Why would he want to hide the full list if he chose to display it?

Various reasons, maybe he has clicked it by mistake or perhaps he wanted to search for a specific name (via ctrl+F) and then hide one list and open the second one.

But it just feels right to have a way of reverting back whatever you've done, I even remember reading about this somewhere, it's how good designs are made.

Make actions reversible – be forgiving

This rule means that the user should always be able to quickly backtrack whatever they are doing. This allows users to explore the product without the constant fear of failure — when a user knows that errors can be easily undone, this encourages exploration of unfamiliar options. On the contrary, if a user has to be extremely careful with every action they take, it leads to a slower exploration and nerve-racking experience that no one wants.

https://xd.adobe.com/ideas/process/ui-design/4-golden-rules-ui-design/

@MahdiTurki
Copy link
Contributor Author

You are totally right. I will keep that in mind in the future.
I will think of a way on how to hide the list and will try to implement it.

@ghost
Copy link

ghost commented Apr 27, 2020

I will think of a way on how to hide the list and will try to implement it.

I hope you meant not to hide the entire list, just revert it back to how it was before the user has clicked that button :)

thank you

@MahdiTurki
Copy link
Contributor Author

I hope you meant not to hide the entire list, just revert it back to how it was before the user has clicked that button :)

My bad! Yes that's what I meant.

@MahdiTurki
Copy link
Contributor Author

Now the user has the option to show the full list, and when it's pressed, the user can scroll down, hide the full list and will only see the first 20 followers/followings.

@rigelk rigelk added the UI non-trivial UI changes, that might need discussion label Apr 28, 2020
@test2a

This comment has been minimized.

@rigelk rigelk linked an issue Aug 14, 2020 that may be closed by this pull request
@kontrollanten
Copy link
Contributor

@rigelk Is there anything more that needs to be done on this (except solving the file conflict)?

Copy link
Collaborator

@rigelk rigelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kontrollanten yes, showing the count of instances. The UI for empty lists has not been worked on either (buttons should not appear), and actions should match the color scheme for links.

@kontrollanten
Copy link
Contributor

@MahdiTurki Thanks for your contribution! Do you think that you can do the last fixes requested by @rigelk ? It would be nice to be able to merge this :)

@MahdiTurki
Copy link
Contributor Author

Hi, sure thing. I will start working on them soon.

and actions should match the color scheme for links.

@rigelk, I don't get what you mean exactly, could you please elaborate more?

@rigelk
Copy link
Collaborator

rigelk commented Dec 3, 2020

@MahdiTurki just have links use the main color 😉

@kontrollanten
Copy link
Contributor

@MahdiTurki just have links use the main color

Is it the Show more/less links that you're thinking of? I guess we should add the button-grey mixin and remove the padding: 0;

image

@rigelk
Copy link
Collaborator

rigelk commented Dec 4, 2020

Either is fine

@MahdiTurki
Copy link
Contributor Author

I managed to display the count of instances. I tested with 2 different instances and it worked fine.
I also managed to hide the show/hide button when there are no followers or followings.

@Chocobozzz Chocobozzz self-assigned this Dec 13, 2020
@Chocobozzz
Copy link
Owner

Merged manually. Thanks @MahdiTurki

@Chocobozzz Chocobozzz closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI non-trivial UI changes, that might need discussion
Projects
None yet
5 participants