Make federation of unlisted videos an instance-level server preference #2802
Conversation
Tak
force-pushed
the
disable-unlisted-federation
branch
from
f1ceba9
to
f0c559b
Compare
| @@ -137,6 +137,11 @@ export class EditCustomConfigComponent extends FormReactive implements OnInit, A | |||
| css: null | |||
| } | |||
| }, | |||
| federation: { | |||
| videos: { | |||
| federateUnlisted: true | |||
There was a problem hiding this comment.
Do you want admins to update this setting on the web interface? If no, you can remove this
There was a problem hiding this comment.
Is there any reason not to allow this? I added it to production.yaml as well, based on your earlier comment.
There was a problem hiding this comment.
Is there any reason not to allow this?
It subjective, but it's not a setting admins will update frequently. So I don't think it's very useful to put this in the admin interface. But you're the one who does, so you're the one who decides :)
There was a problem hiding this comment.
Hm, I guess the main benefit would be discoverability.
I'm open to whatever you think - if you feel like it doesn't belong in the web interface, I'm willing to do the rework.
There was a problem hiding this comment.
Then let's move this out of the web interface. Admins should read the config' file when they install peertube, and we'll mention this in the changelog. You could also mention this setting in https://docs.joinpeertube.org/#/admin-following-instances?id=being-followed-by-an-instance
|
Thanks @Tak! |
As discussed on #944
The previous behavior is the default for the preference.
I've added tests for: