Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aria-hidden to non-descriptive icons #2844

Merged
merged 2 commits into from
Jun 8, 2020
Merged

add aria-hidden to non-descriptive icons #2844

merged 2 commits into from
Jun 8, 2020

Conversation

Pandoraaa
Copy link
Contributor

This PR will add aria-hidden attribute to all non descriptive icons in order to improve a11y (screen readers don't have to read icons).

For example these icons in front of the text in the left panel menu :

image

@rigelk rigelk added Component: Accessibility UI non-trivial UI changes, that might need discussion labels Jun 8, 2020
@rigelk rigelk changed the title Add aria-hidden to non descriptive icons add aria-hidden to non-descriptive icons Jun 8, 2020
@rigelk rigelk merged commit 6ad971d into Chocobozzz:develop Jun 8, 2020
@rigelk
Copy link
Collaborator

rigelk commented Jun 8, 2020

Thanks @Pandoraaa !

@Pandoraaa Pandoraaa deleted the aria-icons branch June 9, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelk rigelk rigelk approved these changes

Assignees
No one assigned
Labels
Component: Accessibility UI non-trivial UI changes, that might need discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pandoraaa @rigelk