add keyboard navigation for video actions #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
added
Component: Accessibility
UI
rigelk
requested changes
Jun 9, 2020
rigelk
requested changes
Jun 10, 2020
Pandoraaa
force-pushed
the
keyboard-navigation
branch
from
ec478ea
to
b8d63bd
Compare
Pandoraaa
force-pushed
the
keyboard-navigation
branch
from
b8d63bd
to
b84650e
Compare
rigelk
approved these changes
Jun 11, 2020
rigelk
changed the title
|
@Pandoraaa I fixed the merge conflicts that were introduced on develop, as well as the background-color that was noticeable in the miniature (and not the watch page, my mistake). It should now be easier to replace existing elements with button elements. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve a11y with keyboard navigation on a video page.
The actions buttons under a video can be activated with the keyboard (tab and enter) and the like dislike buttons now have a aria-label for screen readers.