-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add channel name to create-user admin form #2984
Add channel name to create-user admin form #2984
Conversation
Is it still a WIP? |
Yes, didn't have time to commit my local changes with the fix. |
88ece72
to
98d5aec
Compare
5d83bb2
to
50cd26e
Compare
TODO:
|
3510bda
to
a2308d3
Compare
a2308d3
to
1694698
Compare
Fix tests channel displayName Make channelName in createUser optionnal on server side to not break api Fix auto channelName with createUser in tests
1694698
to
9056837
Compare
Tests have been fixed. |
We don't want to autofill the channel name field depending on the user username like we do in the signup form? |
You mean adding Display name fields ? Otherwise, the goal is also to avoid the generic names "kimsible_channel" and "Main kimsible channel", I don't think automatic fill for something we don't want anymore is the right thing to do. In any case the signup form asks username and channel name (with display names) on separate steps. Display names may be edited by the user after account created. EDIT: Also we can create a modal or an alert when signin if the user has still a display channel name like "Main kimsible channel" and no avatar set |
Required fix : #2970