Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel name to create-user admin form #2984

Merged
merged 6 commits into from
Aug 11, 2020

Conversation

kimsible
Copy link
Contributor

Required fix : #2970

image

@Chocobozzz
Copy link
Owner

Is it still a WIP?

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Jul 23, 2020
@kimsible
Copy link
Contributor Author

Is it still a WIP?

Yes, didn't have time to commit my local changes with the fix.

@kimsible kimsible force-pushed the feat/create-user-channel-name branch 5 times, most recently from 88ece72 to 98d5aec Compare July 29, 2020 14:17
@kimsible kimsible marked this pull request as ready for review July 29, 2020 14:24
@kimsible kimsible changed the title WIP Add channel name to create-user admin form Add channel name to create-user admin form Jul 29, 2020
@kimsible kimsible force-pushed the feat/create-user-channel-name branch 2 times, most recently from 5d83bb2 to 50cd26e Compare August 2, 2020 10:45
@kimsible
Copy link
Contributor Author

kimsible commented Aug 2, 2020

TODO: channelName must be added to createUser api doc as an optionnal parameter.

  • On client side in the admin panel, channelName is required to avoid Main username channel displayName and unwanted unique channel name, this way we follow the signup form which forces the user to give a channel name ;
  • Server side, channelName stays optionnal to not break the api.

@kimsible kimsible force-pushed the feat/create-user-channel-name branch 4 times, most recently from 3510bda to a2308d3 Compare August 2, 2020 20:28
@kimsible kimsible force-pushed the feat/create-user-channel-name branch from a2308d3 to 1694698 Compare August 6, 2020 17:37
Fix tests channel displayName

Make channelName in createUser optionnal on server side to not break api

Fix auto channelName with createUser in tests
@kimsible kimsible force-pushed the feat/create-user-channel-name branch from 1694698 to 9056837 Compare August 6, 2020 18:00
@kimsible
Copy link
Contributor Author

kimsible commented Aug 7, 2020

Tests have been fixed.

@Chocobozzz
Copy link
Owner

We don't want to autofill the channel name field depending on the user username like we do in the signup form?

@kimsible
Copy link
Contributor Author

kimsible commented Aug 10, 2020

We don't want to autofill the channel name field depending on the user username like we do in the signup form?

You mean adding Display name fields ?

Otherwise, the goal is also to avoid the generic names "kimsible_channel" and "Main kimsible channel", I don't think automatic fill for something we don't want anymore is the right thing to do.

In any case the signup form asks username and channel name (with display names) on separate steps.

Display names may be edited by the user after account created.

EDIT: Also we can create a modal or an alert when signin if the user has still a display channel name like "Main kimsible channel" and no avatar set

@Chocobozzz Chocobozzz merged commit 766d13b into Chocobozzz:develop Aug 11, 2020
@Chocobozzz Chocobozzz mentioned this pull request Aug 25, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create user from admin since v2.3.0-rc1
3 participants