Revert user-menu dropdown active class on sub-menu and close outside-click #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimsible
force-pushed
the
fix/user-menu-dropdown-close-on-click
branch
from
01c2e0e
to
828598d
Compare
… on outside click
kimsible
force-pushed
the
fix/user-menu-dropdown-close-on-click
branch
from
828598d
to
7fb5ab5
Compare
|
Thanks |
Chocobozzz
reviewed
Jul 31, 2020
| <span | ||
| *ngIf="isInSmallView" |
There was a problem hiding this comment.
Is this deletion is a mistake?
There was a problem hiding this comment.
I put it back in 805d6a3 (we can revert if it was not a mistake) because it causes duplicate entries in the admin menu
There was a problem hiding this comment.
Yes, thanks. Sorry, it was a mistake, without it would indeed duplicate the entry with one for the modal view and another for the dropdown view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the recent proposition to close the dropdown sub-menu only on outside click and showing a background color on active links.
Now, autoclose is back on click inside and outside and active class is removed, because this active effect class caused some blinking effect on the dropdown.