-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ng-select
for templatable select options
#3035
Conversation
@Chocobozzz I didn't check bundle size, because I think this component could replace Considered this, I didn't try to target the video-update module only. |
😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be happy if you could remove ngx-tag
client/src/app/+videos/+video-edit/shared/video-caption-add-modal.component.html
Show resolved
Hide resolved
client/src/app/+videos/+video-edit/video-add-components/video-import-torrent.component.html
Outdated
Show resolved
Hide resolved
client/src/app/+videos/+video-edit/video-add-components/video-import-url.component.html
Outdated
Show resolved
Hide resolved
14b625c
to
155fc34
Compare
DEBUGGED:
|
67350fc
to
88cb021
Compare
@Chocobozzz I replaced Aside from this, it is mostly on par with previous functionality. Slight differences: channel avatars, instance languages on top of language list and grouped as such. |
client/src/app/shared/shared-forms/select-channel.component.html
Outdated
Show resolved
Hide resolved
client/src/app/shared/shared-forms/select-channel.component.html
Outdated
Show resolved
Hide resolved
client/src/app/shared/shared-forms/select-options.component.html
Outdated
Show resolved
Hide resolved
- create select-tags component to replace ngx-chips - create select-options to factorize option selection in forms - create select-channel to simplify channel selection - refactor tags validation
Having a slightly more customizable select component is required here to display both the label of an option and its description.
ng-select
component, like most select components around, features lazy-loading of remote data - which could prove useful for listing channels in thevideo-edit
view in the future.In this PR I focus on the upload/edit view, but other select usages could use option templates elsewhere.
fixes #3015