Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On touchscreens add content overlay for opened menu #3088

Conversation

kimsible
Copy link
Contributor

fixes: #3087

This PR changes the behaviour of the menu on touchscreens :

  • On all resolution open menu only by user, by default it's closed
  • On opened menu, a content overlay is displayed and body scroll locked to avoid the blinking detached menu effect when scroll.

Also on modal opened (and only for touchscreens) body scroll is locked.

overlay-when-menu-opened-touchscreens

@kimsible kimsible force-pushed the fix/broken-menu-when-scroll-on-touchscreen branch 2 times, most recently from 106e7cd to e3666cf Compare August 15, 2020 16:53
@kimsible kimsible force-pushed the fix/broken-menu-when-scroll-on-touchscreen branch from c53283e to 0c1f831 Compare August 15, 2020 18:25
@kimsible kimsible force-pushed the fix/broken-menu-when-scroll-on-touchscreen branch from 0c1f831 to 61b72e5 Compare August 15, 2020 18:44
@Chocobozzz Chocobozzz merged commit 245b9d2 into Chocobozzz:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On touchscreens blinking detached menu-left, modal-overlay and broken layout when scroll
2 participants