Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct break line display for re-draft comments #3261

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

kimsible
Copy link
Contributor

@kimsible kimsible commented Nov 6, 2020

Fix #3260

@rigelk rigelk merged commit 6a9498e into Chocobozzz:develop Nov 6, 2020
@rigelk
Copy link
Collaborator

rigelk commented Nov 6, 2020

@kimsible thanks for the quick PR!

@kimsible
Copy link
Contributor Author

kimsible commented Nov 6, 2020

@rigelk btw after testing lists with comment, it looks like somewhere we replace break line to <br /> before storing any data. So, it breaks markdown lists.

image

Do we have to disable support of lists in comments ?

@rigelk
Copy link
Collaborator

rigelk commented Nov 6, 2020

Do we have to disable support of lists in comments ?

We don't have to disable it, why do you ask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When editing a comment break line are displayed as <br/> html.
2 participants