-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust registration form width on mobile #3274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use only one query to group width changes in one place.
Please use the mobile-view
breakpoint instead of manually writing its value each time.
@test2a also, can you test this in a browser please? For instance in Firefox, you can use the RDM: https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode |
Hello, Is it still a draft? |
i just updated to mobile-view. can you review this |
@test2a this code doesn't work since this is not how variables are used in SASS. You need to use them with a |
fixed box size was forcing more than 100% screen on mobile devices. this should help
Rebased and corrected lint. Checking visual consistency ASAP. |
Description
updated the desired changes in registration form. now it should be 100% width on reasonable length URLs
@rigelk please have a look at this. i think i managed to get what you were asking
Related issues
Type of change
Has this been tested?
Self-test configuration:
Screenshots
Checklist: