Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust registration form width on mobile #3274

Merged
merged 7 commits into from
Nov 25, 2020
Merged

adjust registration form width on mobile #3274

merged 7 commits into from
Nov 25, 2020

Conversation

test2a
Copy link
Contributor

@test2a test2a commented Nov 9, 2020

Description

updated the desired changes in registration form. now it should be 100% width on reasonable length URLs
@rigelk please have a look at this. i think i managed to get what you were asking

Related issues

Type of change

  • ♻️ Refactor discussed in #
  • ✨ Feature as discussed in #
  • 🐛 Bug Fix
  • 👷 Optimization/Maintenance
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 👍 yes, light tests as follows are enough
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Self-test configuration:

  • NodeJS version:
  • Viewport sizes:
  • Browser name/version:

Screenshots

Checklist:

  • I have read the CONTRIBUTING documentation.
  • I didn't make the linter cry
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation as needed
  • I have made changes to the OpenAPI spec as needed
  • To the best of my knowledge, my changes introduce no known security vulnerability
  • I have corrected any misspellings in my code/comments

Copy link
Collaborator

@rigelk rigelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use only one query to group width changes in one place.
Please use the mobile-view breakpoint instead of manually writing its value each time.

@rigelk
Copy link
Collaborator

rigelk commented Nov 10, 2020

@test2a also, can you test this in a browser please? For instance in Firefox, you can use the RDM: https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode

@test2a test2a marked this pull request as draft November 10, 2020 16:07
@Chocobozzz
Copy link
Owner

Hello,

Is it still a draft?

@test2a
Copy link
Contributor Author

test2a commented Nov 25, 2020

i just updated to mobile-view. can you review this

@rigelk
Copy link
Collaborator

rigelk commented Nov 25, 2020

@test2a this code doesn't work since this is not how variables are used in SASS. You need to use them with a $ prefixing them.

@test2a test2a marked this pull request as ready for review November 25, 2020 13:19
@rigelk
Copy link
Collaborator

rigelk commented Nov 25, 2020

Rebased and corrected lint. Checking visual consistency ASAP.

@rigelk rigelk changed the title adjust registration form width on mobile again adjust registration form width on mobile Nov 25, 2020
@rigelk rigelk merged commit 832a12b into Chocobozzz:develop Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants