Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new default different avatar for channel and account #3326

Conversation

kimsible
Copy link
Contributor

Description

Add a new default avatar based on Featured icons and for each Actor type : VideoChannel and Account.
This way we can easily see when the default avatar referring to a channel or an account.

Related issues

#3324

Has this been tested?

  • 👍 yes, light tests as follows are enough

Default avatar is only a client side display, so the only tests I made are displaying the changed view as the screenshots show bellow.

Screenshots

Account menu
avatar1

Comments
avatar2

Admin tables
avatar3

Account page profile
avatar4

Channel page profile
avatar5

Channel list
avatar6

Video description
avatar7

Search
avatar8

@kimsible kimsible force-pushed the feat/new-default-avatar-channel-and-account branch from 2497266 to 8298585 Compare November 18, 2020 20:44
@Chocobozzz
Copy link
Owner

Hello,

Why removing the old default avatar? I think it's appropriate to define an account, and it's more cheerful than the new avatar.

@kimsible
Copy link
Contributor Author

kimsible commented Nov 19, 2020

Hello,

Why removing the old default avatar? I think it's appropriate to define an account, and it's more cheerful than the new avatar.

@Chocobozzz sorry if you're attached to it, but it's to be consistent with the rest of the design, the image takes the user / account icon of featured icons.

And sorry again if you did that image, it's not against you, but it's not cheerful for me and some other PeerTube users, it's more creepy and weird to use a big smiley to represent a default profile / account avatar, it's not very common. For example, in QueerMotion, no member understood it was a default avatar at the beginning despite the remark that it's creepy :/.

In any case, I don't say it will fix the fact that a user does not fill its profile and set its avatar but it's really better to be consistent with common design « codes » and the rest of the PeerTube design (features icons).

EDIT: I would add that if we want something as cheerful as Mastodon (the head elephant) we can do something around Sepia, but it's out of my skills, maybe sticking to something consistent and more common waiting for a designer does fun default avatars with the mascot is the right choice ?

@Chocobozzz
Copy link
Owner

@Chocobozzz sorry if you're attached to it, but it's to be consistent with the rest of the design, the image takes the user / account icon of featured icons.

I'm not attached to anything. I just argued that the new one is too austere compared to the current one.

And sorry again if you did that image, it's not against you

I did not. Please let's leave my potential personal feelings out of this discussion :)

it's more creepy and weird to use a big smiley to represent a default profile

Then we can search for a better alternative. Your edit seems a good idea. I'll see what I can do but it will take time.

@kimsible
Copy link
Contributor Author

I did not. Please let's leave my potential personal feelings out of this discussion :)

Ok ok =). You put them in the discussion yourself. I understand that a project like PeerTube asks lots of attention and a community (as every community) is not always as cheerful as it should be when it comes to request features or describe an issue, that's why we have to try to not let our personal feelings out too quickly.

Then we can search for a better alternative. Your edit seems a good idea. I'll see what I can do but it will take time.

Maybe we can ask to a designer ? I'll try to find one interested, we have couple of ones in QueerMotion.

@Chocobozzz Chocobozzz merged commit c418d48 into Chocobozzz:develop Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants