add title attribute for exact view counters #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @tanguybernard and thanks for your interest in this issue, You checked the "no, because this PR is a draft and still needs work" checkbox but didn't put it in draft and yet ask for a review in the issue thread. Please either put your PR as draft or ask for a review.
No need to touch translations files, since they are generated strictly from code 🙂 |
rigelk
requested changes
Nov 26, 2020
client/src/app/shared/shared-video-miniature/video-miniature.component.html
Outdated
Show resolved
Hide resolved
rigelk
changed the title
Poslovitch
reviewed
Nov 26, 2020
client/src/app/shared/shared-video-miniature/video-miniature.component.ts
Outdated
Show resolved
Hide resolved
tanguybernard
force-pushed
the
feat-3173-show-exact-number-of-views-hover
branch
from
211fa9d
to
a8c9103
Compare
…to see the details of numbers of views
fix(Chocobozzz#3173): review
tanguybernard
force-pushed
the
feat-3173-show-exact-number-of-views-hover
branch
from
a8c9103
to
6996a8c
Compare
rigelk
requested changes
Nov 26, 2020
client/src/app/shared/shared-video-miniature/video-miniature.component.html
Outdated
Show resolved
Hide resolved
client/src/app/shared/shared-video-miniature/video-miniature.component.ts
Outdated
Show resolved
Hide resolved
rigelk
requested changes
Nov 27, 2020
client/src/app/shared/shared-video-miniature/video-miniature.component.ts
Outdated
Show resolved
Hide resolved
rigelk
approved these changes
Nov 27, 2020
rigelk
changed the title
|
Thanks for your help @rigelk and @Poslovitch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add title for video-watch and video-miniature to see the details of numbers of views
Description
Add information about the exact view of a video or live
Related issues
fixes #3173
Has this been tested?
I asked a question on the issue about the translation, if you can help me :)
#3173 (comment)