-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Markdown formatting in all the fields of the "About" page #3371
Added Markdown formatting in all the fields of the "About" page #3371
Conversation
client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html
Show resolved
Hide resolved
@kimsible |
@Poslovitch My bad, sorry, the default
Though this PR adds markdown to all about textarea I think you can actually delete them, |
Moved creationReason, maintenanceLifetime and businessModel into the html dict
Thanks for the PR @Poslovitch ! LGTM 👍 ! |
Thanks @Poslovitch |
Thank you too 🙂 |
Description
This PR introduces Markdown formatting in additional fields of the instance's "About" page.
It replaces plain-text textareas in the admin configuration by
my-markdown-textarea
as well as adds the<my-help helpType="markdownText"></my-help>
to all of them.It also registers the missing fields into
instance.service.ts
so that their content gets rendered as Markdown.Related issues
Resolves #3368.
Has this been tested?
Since my computer is a bit of a potato, I can't efficiently run Docker on it. Therefore, I developed all of that on Gitpod.
The "new" code reuses the same "code" that previously existed. It was just a matter of tweaking some HTML tags and adding a few fields in
instance.service.ts
. I tested the code by running a dev PeerTube instance and modifying the "config" of the About page a few times (this included: not-formatted text, Markdown-formatted text, blank text fields...).Screenshots
Proof that the Markdown formatting now works in fields it previously didn't: