Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix themes colors by using SCSS variables #3376

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

madmath03
Copy link
Contributor

@madmath03 madmath03 commented Nov 27, 2020

Description

Fix hardcoded colors preventing correct theming.

Funded by @Monogramm.

Related issues

This PR will fix themes displays, like listed in https://framagit.org/framasoft/peertube/official-plugins/-/issues/21 of peertube-theme-dark.

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 👍 yes, light tests as follows are enough
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Screenshots

WIth dark theme:

  • image

image

With default theme:
*
image
*
image

@Chocobozzz
Copy link
Owner

Chocobozzz commented Nov 30, 2020

Hello,

This PR breaks the menu with the default theme
screen_2020-11-30-09:49:34

Try --menuForegroundColor and --menuBackgroundColor instead

@madmath03
Copy link
Contributor Author

Hello,

This PR breaks the menu with the default theme

Try --menuForegroundColor and --menuBackgroundColor instead

Hi @Chocobozzz

done, it should be better now.

@Chocobozzz Chocobozzz merged commit a742b4b into Chocobozzz:develop Nov 30, 2020
@Chocobozzz
Copy link
Owner

Thanks @madmath03

@madmath03 madmath03 deleted the fix/themes branch November 30, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants