Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 1440p (Quad HD/QHD/WQHD) videos #3518

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

rigelk
Copy link
Collaborator

@rigelk rigelk commented Dec 24, 2020

resolves #3500. The CI harness is supposedly enough to catch mistakes but I might need to add 1440p videos to it.

@SimplyCorbett
Copy link

Can you rebase this into branch 4ec1c43?

Thank you!

@rigelk
Copy link
Collaborator Author

rigelk commented Jan 8, 2021

Can you rebase this into branch 4ec1c43?

No, since these changes are unrelated nor is the commit you linked in develop. Why? Do you think they might interfere with each other?

@SimplyCorbett
Copy link

Can you rebase this into branch 4ec1c43?

No, since these changes are unrelated nor is the commit you linked in develop. Why? Do you think they might interfere with each other?

No, I just wanted to test on a more up to date branch. It's all good - I'll pull this as is and apply 3516 as well. Will let you know if there are any bugs :)

@SimplyCorbett
Copy link

I can't get peertube to start with this PR on the latest git but it's probably user error since I'm applying them manually by hand. I'll just wait for it to be merged into master. I'm still unfamiliar with how to do PR pulls correctly.

@rigelk
Copy link
Collaborator Author

rigelk commented Jan 8, 2021

@SimplyCorbett you might want to check out https://cli.github.com/manual/gh_pr_checkout

@Chocobozzz Chocobozzz merged commit b7085c7 into Chocobozzz:develop Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1440p60 support
3 participants