add variant of the "hot" trending algorithm #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rigelk
force-pushed
the
hot
branch
7 times, most recently
from
d99b8c4
to
d287e44
Compare
rigelk
commented
Jan 25, 2021
Chocobozzz
requested changes
Jan 25, 2021
client/src/app/+videos/video-list/trending/video-trending-header.component.ts
Show resolved
Hide resolved
client/src/app/shared/shared-video-miniature/video-list-header.component.ts
Outdated
Show resolved
Hide resolved
client/src/app/shared/shared-video-miniature/video-list-header.component.ts
Outdated
Show resolved
Hide resolved
|
Please add ability for admin to enable/disable trending algorithm + default one |
Chocobozzz
added
the
Status: Requires Tests
rigelk
force-pushed
the
hot
branch
2 times, most recently
from
699bccb
to
a2c9490
Compare
Chocobozzz
previously requested changes
Jan 26, 2021
client/src/app/+videos/video-list/trending/video-trending-header.component.ts
Show resolved
Hide resolved
client/src/app/+videos/video-list/trending/video-trending-header.component.ts
Outdated
Show resolved
Hide resolved
rigelk
force-pushed
the
hot
branch
2 times, most recently
from
aed6740
to
35cc7ff
Compare
|
Please add tests |
rigelk
removed
the
Status: Requires Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current changes don't replace the "Trending" page or behaviour, but merely add a "Hot" variant inspired by Reddit's own algorithm, albeit extended for video to integrate views and comments.
Another change is the modularization of abstract video list titles. Simply setting a string is not enough for more involved and varying interfaces.
Related issues
No issue focused on changing the trending algorithm, just on "customizing" the landing page.
It could be related to #3488 as in standardizing scores will lead up to allowing options to how they are computed: potentially pushing forward local videos if need be.
Has this been tested?
I tested queries on sherri.
Screenshots
Questions
Should I create a dedicated route for the algorithm, much like "trending" has one?