localize decimal separator in video miniatures #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
reviewed
Jan 27, 2021
There was a problem hiding this comment.
Using https://angular.io/api/common/formatNumber would be simpler?
kontrollanten
force-pushed
the
fix-decimal-locale
branch
from
93243ae
to
1fe74db
Compare
kontrollanten
commented
Jan 27, 2021
client/src/app/shared/shared-main/angular/number-formatter.pipe.ts
Outdated
Show resolved
Hide resolved
rigelk
approved these changes
Jan 28, 2021
rigelk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some countries are using comma as decimal separator.
https://caniuse.com/internationalization
Has this been tested?