Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add best trending strategy based on Reddit's best #3681

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

rigelk
Copy link
Collaborator

@rigelk rigelk commented Feb 2, 2021

Description

inspired from https://www.reddit.com/r/changelog/comments/7spgg0/best_is_the_new_hotness/
this implementation only adds freshness, and doesn't personalize based
on subscribed communities yet.

Related issues

None.

Has this been tested?

  • 👍 yes, I added tests to the test suite

Screenshots

Screenshot_2021-02-02 Trending videos - PeerTube

Questions

Should I merge this with hot sort?
Should I only display best sort for logged-in users?

@test2a
Copy link
Contributor

test2a commented Feb 2, 2021

At this rate, isnt it better to also add a "new" so that "recently added" can be shown on that page as well?
It would declutter the sidebar and on trending page the experience would be unified.

Best, hot, likes, views, new.

@rigelk
Copy link
Collaborator Author

rigelk commented Feb 2, 2021

@test2a I don't think age alone can be a measure of trendiness.

@test2a
Copy link
Contributor

test2a commented Feb 2, 2021

On Reddit, the stream is sortable between all these fields. Im basing on that because you imported best and hot from reddit in the first place. Im saying make the experience simpler for users who are new.

Oh, you are saying the tab is "trending" and hence the sorts. Hmm.

@rigelk
Copy link
Collaborator Author

rigelk commented Feb 2, 2021

@test2a we might need the space in the menu in the near future ; in the meantime there's no rush changing things IMHO.

@test2a
Copy link
Contributor

test2a commented Feb 3, 2021

@rigelk while we are at this, views and hot and hopefully best also works on "last 24 hours". is that correct? if yes then why do likes show historical stats like from last year? shouldnt sort by likes too show "most liked in recent videos"?

inspired from https://www.reddit.com/r/changelog/comments/7spgg0/best_is_the_new_hotness/
this implementation only adds freshness, and doesn't personalize based
on subscribed communities yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants