Rewrite prose for JavaScript disabled message #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve the clarity of the message and make it easy to understand what the problem is at a glance. - Clearly show that the page is PeerTube, without having to read the whole prose - Clearly show that the problem is JavaScript, without having to read the whole prose - Reorganise suggestions into a bullet list
rigelk
approved these changes
Feb 3, 2021
|
@cloudrac3r thanks! This is indeed simpler to read and act upon. |
|
Did you test your changes? I found that |
|
yes, I tested them the same way you did. |
|
I can't get it to apply the styles, but I trust that you know more than me, so you're probably doing it right and I'm not. :) Thanks! |
|
what browser are you testing this with? Are you running the instance in a specific mode (dev? prod?)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should improve the clarity of the message and make it easy to
understand what the problem is at a glance.
I figured this was trivial enough that I didn't need to open an issue for discussion first. Just let me know if you have comments :)
Has this been tested?
Yes, manually, by loading the HTML file in a browser with scripts disabled, and checking that the page looked like what I wanted.