Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add channel and playlist stats to server stats endpoint #3747

Merged
merged 3 commits into from
Apr 12, 2021
Merged

add channel and playlist stats to server stats endpoint #3747

merged 3 commits into from
Apr 12, 2021

Conversation

rigelk
Copy link
Collaborator

@rigelk rigelk commented Feb 17, 2021

Description

Adds the number of local playlists, local channels and active local channels on various timeframes (akin to active users stats): daily/weekly/monthly.

Has this been tested?

  • 👍 yes, I added tests to the test suite, though they might not be enough

Chocobozzz
Chocobozzz requested changes Feb 18, 2021
View reviewed changes
server/models/video/video-channel.ts Outdated Show resolved Hide resolved
server/models/video/video-playlist.ts Outdated Show resolved Hide resolved
server/tests/api/server/stats.ts Outdated Show resolved Hide resolved
@rigelk rigelk force-pushed the more-usage-stats branch 2 times, most recently from adbf2bb to a47dd05 Compare February 26, 2021 11:21
@rigelk
Copy link
Collaborator Author

rigelk commented Feb 26, 2021 •
edited
Loading

@Chocobozzz still missing the totalLocalPlaylists tests but otherwise ready for re-review

@rigelk rigelk force-pushed the more-usage-stats branch 3 times, most recently from 4b0fb30 to 10afff2 Compare February 27, 2021 10:28
Chocobozzz
Chocobozzz previously requested changes Mar 2, 2021
View reviewed changes
server/models/video/video-channel.ts Outdated Show resolved Hide resolved
server/tests/api/server/stats.ts Outdated Show resolved Hide resolved
@rigelk rigelk force-pushed the more-usage-stats branch 3 times, most recently from 3cf962e to 2db6f26 Compare April 9, 2021 13:07
@rigelk rigelk requested a review from Chocobozzz April 9, 2021 13:15
@Chocobozzz
Copy link
Owner

Please fix tests

@rigelk rigelk dismissed Chocobozzz’s stale review April 12, 2021 08:53

tests have been fixed

@rigelk rigelk requested review from Chocobozzz and removed request for Chocobozzz April 12, 2021 08:54
@Chocobozzz Chocobozzz merged commit fe19f60 into Chocobozzz:develop Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobozzz Chocobozzz Awaiting requested review from Chocobozzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rigelk @Chocobozzz