fix missing title attribute on <iframe> tag suggested for embedding #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
requested changes
Mar 30, 2021
rigelk
changed the title
Chocobozzz
reviewed
Mar 30, 2021
Chocobozzz
reviewed
Mar 30, 2021
server/tests/api/server/services.ts
Outdated
| @@ -88,7 +88,7 @@ describe('Test services', function () { | |||
|
|
|||
| const res = await getOEmbed(server.url, oembedUrl) | |||
| const expectedHtml = '<iframe width="560" height="315" sandbox="allow-same-origin allow-scripts" ' + | |||
| `src="http://localhost:${server.port}/video-playlists/embed/${playlistUUID}" ` + | |||
| `title="${video.name}" src="http://localhost:${server.port}/video-playlists/embed/${playlistUUID}" ` + | |||
There was a problem hiding this comment.
Should be title="The Life and Times of Scrooge McDuck" since it's the playlist embed
There was a problem hiding this comment.
can i assign directly the string ?
|
Thanks @pthavarasa! |
|
👍 Thanks @pthavarasa and @Chocobozzz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed this issue. Now there is a title in the iframe tag.
share video -> video title
share playlist -> playlist title
share playlist video(right click in the video to copy embed) -> video title