Don't pause video upon modal open #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, You remove a behaviour added on purpose because the community asked for this feature (but I can't find the issue :/). So I'm not sure what we should do. |
|
I couldn't find the issue either. An option could be to make it configurable, but I can't really see any big benefit with auto pausing upon modal open. It may be in some particular cases convenient to have the auto pause, but to me it seems really narrow. I think users expect the video to be playing in as many cases as possible, i.e. in iOS and Android most videos continue to play even when the user closes the browser. |
rigelk
added
Component: Player ⏯️
UI
rigelk
approved these changes
Apr 7, 2021
Chocobozzz
reviewed
Apr 8, 2021
kontrollanten
added a commit
to kontrollanten/PeerTube
that referenced
this pull request
Apr 9, 2021
* client: dont pause video upon modal open closes Chocobozzz#3816 * client(video/watch): remove obsolete code * gitignore: add vscode and vim swp files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the pausing of video upon modal open.
Related issues
Closes #3816
Has this been tested?